Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coding and review agents #65

Merged
merged 23 commits into from
Dec 18, 2023
Merged

Add coding and review agents #65

merged 23 commits into from
Dec 18, 2023

Conversation

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maige ✅ Ready (Inspect) Visit Preview Dec 18, 2023 8:52pm

@ghost ghost added the webhooks GitHub webhook listener and its internal logic: routing based on event; connection to data layer label Dec 8, 2023
* Clean up triage agent prompt
Copy link
Contributor

@arihanv arihanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PR body: ${pr?.body || issue.body}.
`
: `
Issue number: ${issue.number}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of passing the issue number to maige, what if we just input it directly into the tool when we configure the agent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, issueNumber is passed directly to engineer() and issueId is passed to labelTool().

The only remaining tool that might use issueNumber is githubTool() which uses it in an open-ended way. Only idea I have for replacing it is to add to the prompt "write ISSUE_NUMBER any time you want to reference the issue number" then output.replaceAll("ISSUE_NUMBER", issueNumber) but this still requires the LLM to be precise. In need of a long-term solution for this pattern.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does githubTool just accept any random json from the LLM?

}> {
const res = await octokit.graphql(
`
query Labels($name: String!, $owner: String!) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are your thoughts of using octokit.request instead of graphql. Makes it easier I guess to find issues since there's type checking and stuff as well as more readability. More limited than graphql in some extreme cases, but really useful generally.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! In this case it's nice since we can grab repo description + labels in one request, but the others can maybe be replaced by .request(). Will try.

@tedspare
Copy link
Collaborator Author

tedspare commented Dec 13, 2023

Before merging, from @DexterStorey :

  • Must add maige-coder PAT
  • Must add contents READ permission

@tedspare
Copy link
Collaborator Author

maige please review this PR

@tedspare
Copy link
Collaborator Author

maige please review this PR?

@ghost ghost assigned tedspare Dec 18, 2023
@ghost ghost added the 🚨 needs approval 🚨 needs approval label Dec 18, 2023
@ghost
Copy link

ghost commented Dec 18, 2023

@tedspare, it seems you are the author of this PR, so I cannot assign you as a reviewer. If you need a review from a specific person or team, please mention them in a comment or use the GitHub interface to request a review.

By Maige. How's my driving?

@tedspare
Copy link
Collaborator Author

maige beta review this

@@ -1,15 +1,15 @@
import {App} from '@octokit/app'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement for Octokit is not found in the specified file path. Please ensure the correct file is being modified or provide the correct path where Octokit should be imported.

By Maige. How's my driving?

@ghost
Copy link

ghost commented Dec 18, 2023

@tedspare, it seems that you are the author of PR #65 and therefore cannot be assigned as a reviewer. Please assign another reviewer or let me know if there's anything else I can assist you with.

By Maige. How's my driving?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 needs approval 🚨 needs approval webhooks GitHub webhook listener and its internal logic: routing based on event; connection to data layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants