-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coding and review agents #65
Conversation
tedspare
commented
Dec 8, 2023
•
edited
Loading
edited
- [MAR 17, 19, 28, 30] coding agent #53
- Add Reviewer agent to summarize PR. #54
- Arihan/mar 8 ability to comment by line of code in pr #55
- Clean up triage agent prompt #66
Update staging branch with latest commits to Main
* Add reviewer agent for pull request
* Add coding agent
* Add inline code reviews
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Clean up triage agent prompt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR body: ${pr?.body || issue.body}. | ||
` | ||
: ` | ||
Issue number: ${issue.number}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of passing the issue number to maige, what if we just input it directly into the tool when we configure the agent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, issueNumber
is passed directly to engineer()
and issueId
is passed to labelTool()
.
The only remaining tool that might use issueNumber
is githubTool()
which uses it in an open-ended way. Only idea I have for replacing it is to add to the prompt "write ISSUE_NUMBER any time you want to reference the issue number"
then output.replaceAll("ISSUE_NUMBER", issueNumber)
but this still requires the LLM to be precise. In need of a long-term solution for this pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does githubTool just accept any random json from the LLM?
}> { | ||
const res = await octokit.graphql( | ||
` | ||
query Labels($name: String!, $owner: String!) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are your thoughts of using octokit.request instead of graphql. Makes it easier I guess to find issues since there's type checking and stuff as well as more readability. More limited than graphql in some extreme cases, but really useful generally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! In this case it's nice since we can grab repo description + labels in one request, but the others can maybe be replaced by .request()
. Will try.
Before merging, from @DexterStorey :
|
* Add summary function for code snippets
maige please review this PR |
maige please review this PR? |
maige beta review this |
@@ -1,15 +1,15 @@ | |||
import {App} from '@octokit/app' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import statement for Octokit is not found in the specified file path. Please ensure the correct file is being modified or provide the correct path where Octokit should be imported.
By Maige. How's my driving?