Arihan/mar 31 summarize and upsert code snippets from reposplitter #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arihanv
commented
Dec 6, 2023
arihanv
commented
- Automatically write and upsert short summaries of code chunks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
maige could you review this? |
|
maige test |
|
maige comment |
tedspare
reviewed
Dec 13, 2023
lib/utils/embeddings/embed.ts
Outdated
| @@ -42,16 +43,17 @@ export default async function addRepo( | |||
| process.env.GITHUB_ACCESS_TOKEN || '' | |||
| ) | |||
|
|
|||
| const docs = repo.map(doc => { | |||
| const docs = Promise.all(repo.map(async doc => { | |||
There was a problem hiding this comment.
.map(async () => { await someFunc() } might not actually wait
I believe the only JS for loop that respects async-await is for (const doc or repo) { await someFunc() }
There was a problem hiding this comment.
.map(async () => { await someFunc() } -> Why does it not?
tedspare
reviewed
Dec 13, 2023
tedspare
reviewed
Dec 13, 2023
tedspare
reviewed
Dec 13, 2023
tedspare
requested changes
Dec 13, 2023
tedspare
deleted the
arihan/mar-31-summarize-and-upsert-code-snippets-from-reposplitter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.