Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sparql generator for SPARQL 1.1 update ADD, MOVE, COPY operations #151

Merged
merged 2 commits into from
May 24, 2022
Merged

Fix sparql generator for SPARQL 1.1 update ADD, MOVE, COPY operations #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05a334d
Add failing test case for SPARQL 1.1 graph mgmt operations
QuarksToQuasars Apr 11, 2022
fd41ee3
Fix sparql generator for SPARQL 1.1 update ADD, MOVE, COPY operations
QuarksToQuasars Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/SparqlGenerator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,8 @@ Generator.prototype.toUpdate = function (update) {
case 'add':
case 'copy':
case 'move':
return update.type.toUpperCase() + (update.source.default ? ' DEFAULT ' : ' ') +
'TO ' + this.toEntity(update.destination.name);
return update.type.toUpperCase()+ ' ' + (update.silent ? 'SILENT ' : '') + (update.source.default ? 'DEFAULT' : this.toEntity(update.source.name)) +
' TO ' + this.toEntity(update.destination.name);
case 'create':
case 'clear':
case 'drop':
Expand Down
30 changes: 30 additions & 0 deletions test/SparqlGenerator-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,36 @@ describe('A SPARQL generator', function () {
'GROUP BY ?k';
expect(generatedQuery).toEqual(expectedQuery);
});

it('should preserve source graph in sparql 1.1 update ADD operation', function () {
var parser = new SparqlParser();
var parsedQuery = parser.parse('ADD <http://example.com/my-graph> TO <http://example.com/your-graph>');
var generator = new SparqlGenerator();
var generatedQuery = generator.stringify(parsedQuery);
var expectedQuery =
'ADD <http://example.com/my-graph> TO <http://example.com/your-graph>';
expect(generatedQuery).toEqual(expectedQuery);
});

it('should preserve source, default graph in sparql 1.1 update MOVE operation', function () {
var parser = new SparqlParser();
var parsedQuery = parser.parse('MOVE DEFAULT TO <http://example.org/named>');
var generator = new SparqlGenerator();
var generatedQuery = generator.stringify(parsedQuery);
var expectedQuery =
'MOVE DEFAULT TO <http://example.org/named>';
expect(generatedQuery).toEqual(expectedQuery);
});

it('should preserve source, default graph in sparql 1.1 update MOVE operation', function () {
var parser = new SparqlParser();
var parsedQuery = parser.parse('COPY SILENT DEFAULT TO <http://example.org/named>');
var generator = new SparqlGenerator();
var generatedQuery = generator.stringify(parsedQuery);
var expectedQuery =
'COPY SILENT DEFAULT TO <http://example.org/named>';
expect(generatedQuery).toEqual(expectedQuery);
});
});

function testQueries(directory, settings) {
Expand Down