Fix sparql generator for SPARQL 1.1 update ADD, MOVE, COPY operations #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case currently fails and will drop <http://example.com/my-graph>
Previously the generator incorrectly omitted the source graph. Reference https://www.w3.org/TR/sparql11-update/#copy
|
Hi @RubenVerborgh . Any thoughts on this? |
|
Catching up after some health issues, I'll be back soon! |
|
@RubenVerborgh Hello, did you have a chance to look at this PR? |
RubenVerborgh
approved these changes
May 24, 2022
|
Super, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #150.
What is a bit strange IMHO, is that in the standard the GRAPH keyword seems to be optional for ADD, MOVE, COPY (c.f. https://www.w3.org/TR/sparql11-update/#COPY and https://www.w3.org/TR/sparql11-query/#rGraphOrDefault , ) but not for others e.g. https://www.w3.org/TR/sparql11-update/#DROP ("The GRAPH keyword is used to remove a graph denoted by IRIref, the DEFAULT keyword is used to remove the default graph from the Graph Store").
So I haven't checked yet whether it is possible to preserve the GRAPH, for example,
ADD GRAPH <http://example.com/my-graph> TO GRAPH <http://example.com/your-graph>instead ofADD <http://example.com/my-graph> TO <http://example.com/your-graph>. In the current fix it would simply drop the GRAPH keyword in the roundtrip. I guess that may relate to #100 ?