Fix generating triples using shorthand notation when subject/predicate is the same #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @RubenVerborgh !
While updating our SPARQL.js dependency to v3.0 at metaphacts we discovered that some queries are generated without short notation for triple sequence with the same subject or subject-predicate.
Here is an attempt to fix it by structurally comparing RDF/JS terms. There is a helper method
equalTerms()defined to avoid usingTerm.equals()method as it's not available when de-serializing query from JSON.In addition we prepared correct TypeScript typings for SPARQL.js v3.0 (issue #98) which will publish soon on DefinitelyTyped 😄