Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typings to RDF/JS #98

Open
RubenVerborgh opened this issue Jun 23, 2020 · 4 comments
Open

Update typings to RDF/JS #98

RubenVerborgh opened this issue Jun 23, 2020 · 4 comments

Comments

@RubenVerborgh
Copy link
Owner

#73 (comment)

@jacoscaz
Copy link
Contributor

@RubenVerborgh I was having a look at the current typings to see whether I can make a PR for this. Looks to me like the change to be made should focus around the following definition of the Term type:

export type Term = string & { __termBrand: string; };

Do you think it would be enough to change this to use RDF/JS' typings? Or, would it be better to also change the Triple interface to better express which kind of term (named node, literal, ...) can be used as the subject / predicate / object of a triple?

@RubenVerborgh
Copy link
Owner Author

I think regular RDF/JS should suffice indeed, thanks!

@AlexeyMz
Copy link
Contributor

The new typings with RDF/JS terms are merged to DefinitelyTyped 🎉
DefinitelyTyped/DefinitelyTyped#46159

@jacoscaz
Copy link
Contributor

Thank you @AlexeyMz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants