[FIX] Add <html> and </html> to header and footer #7025
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the html tags makes the emails sent out by rocket.chat better compliant with standards, and lowers the chance they'll be marked as spam.
|
thanks @ExTechOp .. I think we also need |
|
Email messages aren't usually formatted like complete web pages, with <head></head> and <body></body> sections. Adding the <html></html> tags should be sufficient at least for the purpose of heuristic-based spam detection – I do not know of any such system that does more extensive html syntax/semantics analysis. |
|
@sampaiodiego and @rodrigok should we add a migration here? |
|
good catch @engelgabriel .. yes we do need. |
karlprieb
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the html tags makes the emails sent out by rocket.chat better compliant with standards, and lowers the chance they'll be marked as spam.
@RocketChat/core
Closes #7001