Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include <html> and </html> in header and footer #7001

Closed
ExTechOp opened this issue May 17, 2017 · 1 comment · Fixed by #7025
Closed

Include <html> and </html> in header and footer #7001

ExTechOp opened this issue May 17, 2017 · 1 comment · Fixed by #7025
Assignees
@sampaiodiego
Labels
feat: email type: improvement
Milestone
0.57.0

Comments

@ExTechOp
Copy link
Contributor

Rocket.Chat Version: 0.56.0
Running Instances: 1
DB Replicaset OpLog: Disabled
Node Version: v4.5.0

In file Rocket.Chat/packages/rocketchat-lib/server/startup/settings.js the default Email_Header and Email_Footer values should include a preceding <html> and a trailing </html> respectively, or the emails sent by Rocket.chat will get spam points from SpamAssassin due to technically malformed html (typical of spam messages).
@sampaiodiego
Copy link
Member

thanks for the report.. as you have already correctly found the place to fix it, do you mind to make a pull request with the recommended solution? we would be more than glad to accept it =)

@ExTechOp ExTechOp mentioned this issue May 19, 2017
Merged
@engelgabriel engelgabriel added this to the 0.57.0 milestone May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sampaiodiego sampaiodiego

Labels
feat: email type: improvement
Projects
None yet
Milestone
0.57.0
Development

Successfully merging a pull request may close this issue.

[FIX] Add <html> and </html> to header and footer ExTechOp/Rocket.Chat
4 participants
@engelgabriel @sampaiodiego @ExTechOp @MartinSchoeler