Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clicking repeatedly on 'create' button result in multiple discusions created #33985

Merged
merged 8 commits into from
Nov 19, 2024
+21 −5
Merged

fix: Clicking repeatedly on 'create' button result in multiple discusions created #33985

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f7436e
fix: Clicking repeatedly on 'create' button result in multiple discus…
MartinSchoeler Nov 18, 2024
f1ec30d
Create happy-stingrays-provide.md
MartinSchoeler Nov 18, 2024
26a038b
test: Check if only one discussion is being created
MartinSchoeler Nov 19, 2024
c9c2442
Merge branch 'develop' into fix-disc
MartinSchoeler Nov 19, 2024
6c8e25e
test: fix reviews
MartinSchoeler Nov 19, 2024
8e976ca
fix: e2e test
dougfabris Nov 19, 2024
0499431
Merge branch 'develop' into fix-disc
MartinSchoeler Nov 19, 2024
8f389c2
test: fix locator
dougfabris Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/meteor/tests/e2e/message-actions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,15 +137,20 @@ test.describe.serial('message-actions', () => {

test('expect create a discussion from message', async ({ page }) => {
const message = `Message for discussion - ${Date.now()}`;
const discussionName = `Discussion Name - ${Date.now()}`;

await poHomeChannel.content.sendMessage(message);
await poHomeChannel.content.openLastMessageMenu();
await page.locator('role=menuitem[name="Start a Discussion"]').click();
const createButton = page.getByRole('dialog').getByRole('button', { name: 'create' });
// Name should be prefilled thus making the create button enabled
await expect(createButton).not.toBeDisabled();
await page.locator('role=textbox[name="Name"]').fill(discussionName);
MartinSchoeler marked this conversation as resolved.
Show resolved Hide resolved
await createButton.click();
await expect(page.locator('header h1')).toHaveText(message);
await expect(page.locator('header h1')).toHaveText(discussionName);
await poHomeChannel.sidenav.openChat(targetChannel);
// Should fail if more than one discussion has been created
await expect(page.locator('div.messages-box').getByText(discussionName)).toBeVisible();
MartinSchoeler marked this conversation as resolved.
Show resolved Hide resolved
});

test('expect star the message', async ({ page }) => {
Expand Down
Loading