-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clicking repeatedly on 'create' button result in multiple discusions created #33985
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 3b97197 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33985 +/- ##
========================================
Coverage 75.73% 75.73%
========================================
Files 507 507
Lines 21799 21799
Branches 5343 5343
========================================
Hits 16509 16509
Misses 4648 4648
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes (including videos or screenshots)
The discussion modal submit button isn't being blocked while submitting the form based on the mutation. This PR aims to add the loading prop to the button, based on the mutation loading state in order to prevent multiple clicks while submitting it
Issue(s)
CORE-607
Steps to test or reproduce
Further comments