Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Allow inviting livechat managers to the same LiveChat room #10956

Merged
merged 17 commits into from
Jun 4, 2018

Conversation

renatobecker-zz
Copy link

Closes #9822
Closes #8234
Closes #8235

This fix allows to invite other agents to join the same current chat.
Now, we are using the _id property as a route parameter, instead of using the code property.
So the room link can be shared with other agents.

Additional information:
When a new agent accepts the invitation to participate in a LiveChat room, the visitor will no longer be notified.

@renatobecker-zz renatobecker-zz added this to the 0.66.0 milestone May 30, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10956 May 30, 2018 21:53 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10956 May 30, 2018 21:58 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10956 May 31, 2018 00:45 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10956 May 31, 2018 00:49 Inactive
@RocketChat RocketChat deleted a comment May 31, 2018
@RocketChat RocketChat deleted a comment May 31, 2018
@RocketChat RocketChat deleted a comment May 31, 2018
@RocketChat RocketChat deleted a comment May 31, 2018
@RocketChat RocketChat deleted a comment May 31, 2018
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-10956 June 1, 2018 14:25 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10956 June 4, 2018 03:21 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10956 June 4, 2018 03:30 Inactive
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@RocketChat RocketChat deleted a comment Jun 4, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10956 June 4, 2018 03:34 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10956 June 4, 2018 03:43 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-10956 June 4, 2018 12:27 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-10956 June 4, 2018 12:46 Inactive
@sampaiodiego sampaiodiego changed the title [FIX] Allow inviting other agents to the same LiveChat room [FIX] Allow inviting livechat managers to the same LiveChat room Jun 4, 2018
@sampaiodiego sampaiodiego merged commit 9a13335 into develop Jun 4, 2018
@sampaiodiego sampaiodiego deleted the livechat-invite-agents branch June 4, 2018 18:50
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants