[FIX] Add additional condition for option "Show on unread" #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional condition for option "Show on unread" to show Rocket.Chat window
@RocketChat/electron
Closes #1003
The strange behavior of the function
isFocused()or a bug in it.After closing the application to tray (and no to click anywhere), the focus still remains in the application window (
isFocused()returnTrue). If client received a message in this moment then "show on unread" option is not working correctly (No window shown). In this caseisFocused()returnedTrue, butisVisible()returnedFalse.If after that we change focus manually (for example click anywhere or go to another window) then function
isFocused()returnedFalse(as expected) andisVisible()returnedFalsetoo.In order to solve this problem, added an additional condition that handles this situation and shows a window.
The described issue is displayed in this video.