-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Windows 10 and 8 notification. Bug with option "Show on unread messages". #1003
Comments
No changes were made to "Show on unread messages". Is there any errors logged in console? |
May be it was broken in past? I just simulate it on my fresh installation. After I unchecked "Show on unread messages" and checked it again then I had this issue. There are no errors in the console (both "Show on unread" issue and popup notification issue) |
I'll take I look at it. BTW, I guess I didn't understand correctly the issue about notifications. In your video, the toast notification are shown normally... I guess they are the "popup" notifications you talked about? |
In the video is a clean installation. In it, as in most other computers, everything is fine with pop-up notifications (as in 2.13.3). But we have computers with Windows 10 and Windows 8 where this problem exists. I unfortunately can not make videos from these computers. On them, as I wrote earlier in 2.13.3 was an js error. And in the current version there is no error, but there is also no pop-up notification. Popup with notification dont show and there are no error messages in console. |
There is a possibility: an error is happening in the main process (the one that start the renderer ones, a.k.a. the windows) and it's being silently logged in stdout. One way to check this hypothesis is to run |
Ok, I will try it tomorrow. May be it will give more information. |
I collected application logs. In Windows 10 installation there is the same error as in version 2.14.3. The size of notification tag is too large. According to the information (windows dev center), the size should not exceed 16 characters (to support work in older systems).
For Windows 8, the error is different and is shown in the log below. "No such interface supported" |
Version of Windows 10 is 1511 (build 10586.1176). Just now found one more pc with this Windows version. Problem with notifications is present. |
@tassoevan In addition to issue with "Show on unread" may be it is possible to setup this option by default? It is very hard to describe to all users that the client have this possibilities and they must use it if they dont want to miss messages when client is hidden. |
@tassoevan I made build version with your last commits. And then I was tested it on our computers with a problems. Errors are still present and they are the same with a past versions.
|
@abicur I haven't pushed it yet, but I applied a restriction in the tag size (which is no big deal, since the tags generated by Rocket.Chat are random 17-byte hashes). However, I still didn't make it work for Windows 8. |
@tassoevan first of all, thank you very much for your work.
As I said erly, I readed in "windows dev center" that tags length must be 16 characters for old systems (as window 10 build 1511). And I believe it would solve a problem on those systems. If you push this changes or give me your dev build then I can test it on our computers with windows 10 (build 1511).
Is it possible to use |
Turns out that not even Slack solves the original issue that I expected to fix by the adoption of |
@tassoevan what we will lose when default notification is used? What about notification duration? |
There is no way to customize the toast notification, which means, at this time, not having an option to reply directly on it (which is present in MacOS).
We are going to still be limited by around 20 seconds; no notifications in Action Center after that.
It worked normally in my tests, which is somewhat frustrating. You'd like to propose debug these lines: https://github.com/RocketChat/Rocket.Chat.Electron/blob/develop/src/scripts/events.js#L173-L182
Not yet. |
So, notification duration settings will not work? It is bad news :(
May be I will try to do this on at weekends.
Why is it not possible to do? I think this is a very useful option. And its benefits are even more obvious if notifications are shown for only 20 seconds. In other case it is very easy to miss a message. |
It's not possible yet because we didn't developed a consistent way to handle these settings/preferences that might be overridden by an administrator user. I don't like the idea to add another file along with the already existing |
Since it is not yet possible to determine these settings by the administrator (a very convenient option), is it possible to enable this option by default at least in new installations? |
My Setup
Description
Popup with notification is not shown. Option "Show on unread message" is not work. I can simulate it on some of our computers.
Current Behavior
Expected Behavior
The text was updated successfully, but these errors were encountered: