feat: add reply to message functionality #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiral-Memory
force-pushed
the
feat/quote-msg
branch
5 times, most recently
from
78ee12b
to
36bcec4
Compare
Spiral-Memory
force-pushed
the
feat/quote-msg
branch
from
1ae51bb
to
fb65b60
Compare
Spiral-Memory
force-pushed
the
feat/quote-msg
branch
from
d581393
to
9c30a06
Compare
Spiral-Memory
force-pushed
the
feat/quote-msg
branch
from
0f6f999
to
8768760
Compare
|
Hey @sidmohanty11 , currently, I've added support for quoting a single message in EC. In RC, multiple messages can also be quoted, but I'm not adding that feature for now, as we typically reply to a single message. It can be added later on if necessary. Currently, I don't think that will be a valuable addition. What's your opinion on this? Also, while quoting attachments, in RC, it shows image preview and download button, which I feel is unnecessary considering an in-chat app. Please do let me know your thoughts. If required, I will add those or later if required, it can be added. Additionally, the UI for when recursive messages are quoted is being handled for both the normal UI and for this addition as well in Issue #563 by Akshun. |
Spiral-Memory
changed the title
sidmohanty11
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
This PR adds a feature to quote message
Acceptance Criteria fulfillment
Fixes #560
Video/Screenshots
2024-04-12.23-48-04.mp4