-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] UI inconsistencies in quoted messages #563
Comments
Hey Contributors, This is a very good issue to work on. If anyone is looking for an issue, it would be great to work on this one. I will work on it if no one shows interest. Otherwise, feel free to raise a PR for it. |
Hey, nice find! Working on it 🚀 |
Great ! |
Hi, Just an update from my side! I have implemented the features mentioned in the issue. Just waiting for the quote message PR to get merged. Then I will make final changes and make a PR. NOTE: I have not added the CSS for attachments as of now. It will be similar to what is with Text quoting. And, I would add it in the final PR. Thankyou! ^^ |
Looks awesome 😳😲 |
Description:
Steps to reproduce:
Expected behavior:
UI consistency while quoting messages
Even in case of recursive quoted messages, the UI should render correctly (Refer to RC)
In case of attachment messages quoted, the preview should display correctly (In video, i have shown w.r.t image, test it with multiple attachments and ensure that everything is rendering properly.
Actual behavior:
UI inconsistencies are present and UI fails to render properly when recursive messages are quoted.
2024-04-12.22-50-03.mp4
Note: I think the code is written in PinnedAttachment.js for rendering, make sure it must not break or change pinned message notification UI
Edit: The same has to be handled in QuoteAttachment preview as well.
2024-04-12.23-55-52.mp4
The text was updated successfully, but these errors were encountered: