Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix turning off modal overlay in successive tour starts #277

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Fix turning off modal overlay in successive tour starts #277

merged 2 commits into from
Nov 28, 2018

Commits on Nov 28, 2018

  1. Fix turning off modal overlay in successive tour starts 

    Currently, the `showOrHideModal` function is being called for each step
on the `'hide' and 'destroy' events. This has the effect of calling it before
showing a tour again after closing it.

Moving the hide call up to the service itself fixes this.
    @BrianSipple
    BrianSipple committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    6073a2f View commit details
    Browse the repository at this point in the history

  2. Update environment.js

    @RobbieTheWagner
    RobbieTheWagner authored Nov 28, 2018
    Configuration menu
    Copy the full SHA
    9a141ca View commit details
    Browse the repository at this point in the history