Fix turning off modal overlay in successive tour starts #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianSipple
force-pushed
the
fix-modal-overlay-toggling
branch
2 times, most recently
from
e5f7b59
to
5ed276f
Compare
RobbieTheWagner
requested changes
Nov 26, 2018
addon/services/tour.js
Outdated
| * @private | ||
| */ | ||
| _showOrHideModal(showOrHide) { | ||
| const show = showOrHide === 'show'; | ||
| _showModalOverlay() { |
There was a problem hiding this comment.
Why did we split this function up? Code Climate doesn't like that we have essentially the same code twice. Can we please keep it as one function?
There was a problem hiding this comment.
I was thinking that an explicit function would be less error prone: no manual arg passing and parsing. I can change it back, though.
There was a problem hiding this comment.
@rwwagner90 Out of curiosity, though, Is there a way to tell Code Climate to chill?
There was a problem hiding this comment.
I tend to prefer to keep things DRY and not have two functions that are essentially the same. We can definitely tweak Code Climate too though. There is probably a setting for number of lines of duplication before it flags it.
Currently, the `showOrHideModal` function is being called for each step on the `'hide' and 'destroy' events. This has the effect of calling it before showing a tour again after closing it. Moving the hide call up to the service itself fixes this.
BrianSipple
force-pushed
the
fix-modal-overlay-toggling
branch
from
5ed276f
to
6073a2f
Compare
RobbieTheWagner
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
showOrHideModalfunction is being called for each stepon the
hideanddestroyevents. This leads to it getting called before a tour is re-shown -- after being shown once and then closed:Moving the hide call up to the service itself fixes this.