Make the liked icon configurable #659
Conversation
| show_loading_indicator: true | ||
| # Determines the text icon to display next to "liked" Spotify items, such as | ||
| # liked songs and albums, or followed artists. Can be any length string. | ||
| liked_icon: "♥" |
There was a problem hiding this comment.
My reservation is here. Technically, in almost all cases this is indeed the "liked icon". However, for artists, one "follows" them, so it kind of breaks there.
I considered some alternative names like "tracked_icon" or similar, but it just didn't feel right. Open to any renaming ideas.
|
Hey. I really like this. Thank you. Would you like to implement this for other icons, like shuffle, repeat and currently playing. I'm working on a cli and using icons a lot so I'm gonna implement that. |
|
@OrangeFran It's unclear from your message, are you asking if I'd be interested in implementing custom icons for other things besides this, or are you saying you're going to be doing that? |
|
Sorry, I meant that I'm gonna change from static icons to the configured ones in my fork of the project after this PR gets merged. I wanted to ask if you would be interested in doing the same for other icons. Hopefully this cleares things up. |
|
I think I get it. Yeah, I was thinking of doing it for the current arrow marker as well. Not aware of other icons though. Granted, I've never tried shuffle. You mention for example, repeat, but there is no repeat text icon. Does that mean you're suggesting we add one? For example, Repeat currently just uses a string, e.g., |
|
Yeah, adding a repeat icon would be cool. But there probably should be a seperate PR for that. I thought they were already there, my bad, because I'm working on feature myself where I use repeat and shuffle icons and thought they were already implemented in the code. |
|
No worries. But yes, there really aren't any other icons besides the one made configurable in this PR and the current marker (arrow). We could perhaps add configurable ones for repeat/shuffle, but I'm unsure of what valid options there could be. For example, a simple search for "repeat" and "loop" over the unicode characters do not reveal many sensible options. Especially considering that repeat has various modes, it becomes even harder to distinguish them. Did you have particular icons in mind? |
|
True, I thought of nerd font icons. They have pretty nice shuffle and repeat icons. But there are no unicode icons, at least I didn't find any. Maybe that's the reason that there aren't any more icons implemented. |
|
Yeah, nerd font, font awesome, etc, could open the doors to something that applies. In either case, definitely doable. This PR shows it shouldn't be too bad to extend to a few more possibilities. I'm open to doing it if there's interest and @Rigellute is OK with it. |
* Add liked icon to config and use it over the default * Add padding to the liked icon * Add new liked_icon option to README.md * Fix issue with double-padding
This closes #625.
Sorry this took longer than it should have. I got distracted.
Anyways, it's a pretty simple change. I only have one reservation about the naming.
Here's a screenshot of it in action:
And here's the accompanying config: