Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the liked icon configurable #625

Closed
Utagai opened this issue Oct 19, 2020 · 3 comments · Fixed by #659
Closed

Make the liked icon configurable #625

Utagai opened this issue Oct 19, 2020 · 3 comments · Fixed by #659

Comments

@Utagai
Copy link
Contributor

Utagai commented Oct 19, 2020

Currently, the icon spt uses to mark liked items, such as a liked song, is the heart character: ♥.

For any variety of reasons, the user may want to change their preferred icon. e.g.:

  1. Their font family does not support the glyph.
  2. Their terminal does not render it properly.
  3. Preference

For me, #1 applies, so I unfortunately have an empty space whenever I see a liked song. I was thinking that we could make the default value stay as the ♥, but allow users to configure a replacement string if they wish.

@Utagai
Copy link
Contributor Author

Utagai commented Oct 19, 2020

@Rigellute Let me know if this is something you'd be OK with in spotify-tui. I would be more than willing to work on this as it affects me currently.

Also, it seems like the way we add on the icon is duplicated throughout the code, making it pretty easily error-prone. Let me know what you think about giving a shot at cleaning that up.

If not, that's cool too. I can work off of my fork.

@Rigellute
Copy link
Owner

Yep, happy for this to be added to the config 👍

@Utagai
Copy link
Contributor Author

Utagai commented Oct 21, 2020

Great to hear. I'll take a crack at this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants