[Diagnostics] Add backend_error_code property
#4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
changed the title
backend_error_code property
tonidero
force-pushed
the
diagnostics-add-backend-error-code
branch
from
892222e to
4b48f46
Compare
jamesrb1
approved these changes
Sep 3, 2024
| resultOrigin: response.origin, | ||
| verificationResult: verificationResult) | ||
| case let .failure(error): | ||
| var responseCode = -1 | ||
| if case let .errorResponse(_, code, _) = error { | ||
| var backendErrorCode: Int? |
There was a problem hiding this comment.
I like using nil to represent the absence of a value (as this new code does), but we now seem to be mixing conventions now for "empty": -1 for responseCode and nil for backendErrorCode. Not necessarily recommending a change here, but just surfacing this in case it hadn't been considered.
There was a problem hiding this comment.
That's a good point... And yeah, I also prefer to send nil for these cases... I think it's something that can be changed separately to avoid changing the data we send though. Good callout!
vegaro
pushed a commit
that referenced
this pull request
Sep 5, 2024
**This is an automatic release.** ### Bugfixes * [Customer Center] Build `WrongPlatformView` from JSON (#4234) via Cesar de la Vega (@vegaro) * Add `feedbackSurveyCompleted` event to Customer Center events (#4194) via Cesar de la Vega (@vegaro) ### Other Changes * [Diagnostics] Add `backend_error_code` property (#4236) via Toni Rico (@tonidero) * Update README.md (#3986) via Khoa (@onmyway133)
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
<!-- Thank you for contributing to Purchases! Before pressing the "Create Pull Request" button, please provide the following: --> ### Checklist - [ ] If applicable, unit tests - [ ] If applicable, create follow-up issues for `purchases-android` and hybrids ### Motivation <!-- Why is this change required? What problem does it solve? --> <!-- Please link to issues following this format: Resolves #999999 --> ### Description This adds the `backend_error_code` property to diagnostics `http_request_performed` events.
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
**This is an automatic release.** ### Bugfixes * [Customer Center] Build `WrongPlatformView` from JSON (#4234) via Cesar de la Vega (@vegaro) * Add `feedbackSurveyCompleted` event to Customer Center events (#4194) via Cesar de la Vega (@vegaro) ### Other Changes * [Diagnostics] Add `backend_error_code` property (#4236) via Toni Rico (@tonidero) * Update README.md (#3986) via Khoa (@onmyway133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
Description
This adds the
backend_error_codeproperty to diagnosticshttp_request_performedevents.