Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Customer Center] Build WrongPlatformView from JSON #4234

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Aug 30, 2024

Build WrongPlatformView using Strings from the JSON

Cleaned up the view as well so the logic is simpler and looks cleaner

Simulator Screenshot - iPhone 15 Pro - 2024-08-30 at 18 43 15

@@ -133,6 +138,16 @@ public struct CustomerCenterConfigData {
return "Update"
case .updateWarningIgnore:
return "Continue"
case .platformMismatch:
return "Platform mismatch"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to talk about this. I went through different ideas, even not showing a title at all. Let me know what you think

image

@vegaro vegaro requested a review from a team August 30, 2024 16:53
case .platformMismatch:
return "Platform mismatch"
case .pleaseContactSupportToManage:
return "Please contact support to manage your subscription."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not for this PR, but would be great if there were a link/button that would take them directly to contacting support from this page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That button is probably something you can configure from the JSON :)

case .pleaseContactSupportToManage:
return "Please contact support to manage your subscription."
case .appleSubscriptionManage:
return "You can manage your subscription via the App Store app on an Apple device."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably replace "via" with "by using" here, but just an opinion. But actually, can you with the app store app? I think this needs to be managed in Settings or via your AppleID somehow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I will update the text. You can actually manage the subscriptions in the app store by clicking the profile pic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can actually manage the subscriptions in the app store by clicking the profile pic

TIL!

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vegaro vegaro merged commit 4591a89 into main Sep 3, 2024
5 checks passed
@vegaro vegaro deleted the build-wrong-platform-json branch September 3, 2024 17:29
vegaro pushed a commit that referenced this pull request Sep 5, 2024
**This is an automatic release.**

### Bugfixes
* [Customer Center] Build `WrongPlatformView` from JSON (#4234) via
Cesar de la Vega (@vegaro)
* Add `feedbackSurveyCompleted` event to Customer Center events (#4194)
via Cesar de la Vega (@vegaro)
### Other Changes
* [Diagnostics] Add `backend_error_code` property (#4236) via Toni Rico
(@tonidero)
* Update README.md (#3986) via Khoa (@onmyway133)
nyeu pushed a commit that referenced this pull request Oct 2, 2024
Build `WrongPlatformView` using Strings from the JSON

Cleaned up the view as well so the logic is simpler and looks cleaner

![Simulator Screenshot - iPhone 15 Pro - 2024-08-30 at 18 43
15](https://github.com/user-attachments/assets/9f1dd232-b884-4c72-9666-8774dade8af0)
nyeu pushed a commit that referenced this pull request Oct 2, 2024
**This is an automatic release.**

### Bugfixes
* [Customer Center] Build `WrongPlatformView` from JSON (#4234) via
Cesar de la Vega (@vegaro)
* Add `feedbackSurveyCompleted` event to Customer Center events (#4194)
via Cesar de la Vega (@vegaro)
### Other Changes
* [Diagnostics] Add `backend_error_code` property (#4236) via Toni Rico
(@tonidero)
* Update README.md (#3986) via Khoa (@onmyway133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants