-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Customer Center] Build WrongPlatformView
from JSON
#4234
Conversation
@@ -133,6 +138,16 @@ public struct CustomerCenterConfigData { | |||
return "Update" | |||
case .updateWarningIgnore: | |||
return "Continue" | |||
case .platformMismatch: | |||
return "Platform mismatch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case .platformMismatch: | ||
return "Platform mismatch" | ||
case .pleaseContactSupportToManage: | ||
return "Please contact support to manage your subscription." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not for this PR, but would be great if there were a link/button that would take them directly to contacting support from this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That button is probably something you can configure from the JSON :)
case .pleaseContactSupportToManage: | ||
return "Please contact support to manage your subscription." | ||
case .appleSubscriptionManage: | ||
return "You can manage your subscription via the App Store app on an Apple device." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably replace "via" with "by using" here, but just an opinion. But actually, can you with the app store app? I think this needs to be managed in Settings or via your AppleID somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I will update the text. You can actually manage the subscriptions in the app store by clicking the profile pic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually manage the subscriptions in the app store by clicking the profile pic
TIL!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
**This is an automatic release.** ### Bugfixes * [Customer Center] Build `WrongPlatformView` from JSON (#4234) via Cesar de la Vega (@vegaro) * Add `feedbackSurveyCompleted` event to Customer Center events (#4194) via Cesar de la Vega (@vegaro) ### Other Changes * [Diagnostics] Add `backend_error_code` property (#4236) via Toni Rico (@tonidero) * Update README.md (#3986) via Khoa (@onmyway133)
Build `WrongPlatformView` using Strings from the JSON Cleaned up the view as well so the logic is simpler and looks cleaner ![Simulator Screenshot - iPhone 15 Pro - 2024-08-30 at 18 43 15](https://github.com/user-attachments/assets/9f1dd232-b884-4c72-9666-8774dade8af0)
**This is an automatic release.** ### Bugfixes * [Customer Center] Build `WrongPlatformView` from JSON (#4234) via Cesar de la Vega (@vegaro) * Add `feedbackSurveyCompleted` event to Customer Center events (#4194) via Cesar de la Vega (@vegaro) ### Other Changes * [Diagnostics] Add `backend_error_code` property (#4236) via Toni Rico (@tonidero) * Update README.md (#3986) via Khoa (@onmyway133)
Build
WrongPlatformView
using Strings from the JSONCleaned up the view as well so the logic is simpler and looks cleaner