[Paywalls V2] Adds image background tests #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly build the StackComponentStyle and TextComponentStyle.
JayShortway
commented
Dec 10, 2024
Comment on lines
-40
to
+42
| model = imageUrls.webp, | ||
| model = imageUrls.webp.toString(), | ||
| placeholder = rememberAsyncImagePainter( | ||
| model = imageUrls.webpLowRes, | ||
| model = imageUrls.webpLowRes.toString(), |
There was a problem hiding this comment.
This bug was caught by the tests. It caused the image to not load at all, as we don't have a Fetcher that supports the URL type.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1967 +/- ##
=======================================
Coverage 81.87% 81.87%
=======================================
Files 260 260
Lines 8493 8493
Branches 1226 1226
=======================================
Hits 6954 6954
Misses 1041 1041
Partials 498 498 ☔ View full report in Codecov by Sentry. |
# Conflicts: # ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/style/StyleFactoryTests.kt
tonidero
approved these changes
Dec 10, 2024
tonidero
pushed a commit
that referenced
this pull request
Dec 12, 2024
**This is an automatic release.** ## RevenueCatUI SDK ### 🐞 Bugfixes * Fix multi-tier template to allow optional header image (#1971) via Josh Holtz (@joshdholtz) ### 🔄 Other Changes * [Paywalls V2] Adds first version of `LoadedPaywallComponents` (#1970) via JayShortway (@JayShortway) * [Paywalls V2] Add `ButtonComponentView` (#1963) via Toni Rico (@tonidero) * [Paywalls V2] Adds `PaywallState.Loaded.Components` (#1969) via JayShortway (@JayShortway) * [Paywalls V2] Adds image background tests (#1967) via JayShortway (@JayShortway) * [Paywalls V2] `TextComponentView` updates when the theme changes (#1966) via JayShortway (@JayShortway) * [Paywalls V2] Adds a `StyleFactory` (#1965) via JayShortway (@JayShortway) * [EXTERNAL] fix: update polish translations (#1919) via @radko93 (#1964) via JayShortway (@JayShortway) * [Paywalls V2] Adds `ImageComponentView` (#1959) via Toni Rico (@tonidero) * WebPurchaseRedemption: Rename `AlreadyRedeemed` result to `PurchaseBelongsToOtherUser` (#1962) via Toni Rico (@tonidero) * [Paywalls V2] Extends support for blurred shadows to all Android versions (#1957) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can't easily have
@Previews for remote images (*) and thus don't have snapshot tests for image backgrounds. This PR adds unit tests to verify them instead. It caught a bug too (highlighted below).(*): we might be able to do something with the
FakeImageLoaderEnginein previews too, although we need to be careful not to ship this to production. Something we could look into later.