Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paywalls V2] Extends support for blurred shadows to all Android versions #1957

Merged
merged 73 commits into from
Dec 5, 2024

Conversation

JayShortway
Copy link
Member

@JayShortway JayShortway commented Dec 3, 2024

Alternative title: Removes WithShadow in favor of a .shadow() modifier. (I figured it out yay 🎉)

This uses BlurMaskFilter, which has been available since API level 1, so this .shadow() modifier now works as expected across all API levels.

# Conflicts:
#	purchases/src/main/kotlin/com/revenuecat/purchases/paywalls/components/properties/ColorInfo.kt
#	purchases/src/main/kotlin/com/revenuecat/purchases/paywalls/components/properties/Size.kt
# Conflicts:
#	purchases/src/main/kotlin/com/revenuecat/purchases/paywalls/components/properties/ColorInfo.kt
#	purchases/src/main/kotlin/com/revenuecat/purchases/paywalls/components/properties/Size.kt
…Data and the PartialTextComponent constructor public.
Copy link

emerge-tools bot commented Dec 3, 2024

📸 Snapshot Test

3 modified, 4 added, 4 removed, 103 unchanged

Name Added Removed Modified Unchanged Errored Approval
TestPurchasesUIAndroidCompatibility
com.revenuecat.testpurchasesuiandroidcompatibility
4 4 3 103 0 ✅ Approved

🛸 Powered by Emerge Tools

@JayShortway JayShortway requested review from a team December 3, 2024 14:07
@JayShortway JayShortway marked this pull request as ready for review December 3, 2024 14:07
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.87%. Comparing base (10a0e7b) to head (6353c5d).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           pw2-stackcomponentview    #1957   +/-   ##
=======================================================
  Coverage                   81.87%   81.87%           
=======================================================
  Files                         260      260           
  Lines                        8493     8493           
  Branches                     1226     1226           
=======================================================
  Hits                         6954     6954           
  Misses                       1041     1041           
  Partials                      498      498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JayShortway JayShortway changed the title [Paywalls V2] Removes WithShadow in favor of a shadow() modifier. [Paywalls V2] Extends support for blurred shadows to all Android versions Dec 3, 2024
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Great job on this 💪 !

Base automatically changed from pw2-stackcomponentview to main December 4, 2024 14:33
# Conflicts:
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentView.kt
@JayShortway JayShortway merged commit e8f1a21 into main Dec 5, 2024
10 checks passed
@JayShortway JayShortway deleted the pw2-shadows-v2 branch December 5, 2024 09:24
tonidero pushed a commit that referenced this pull request Dec 12, 2024
**This is an automatic release.**

## RevenueCatUI SDK
### 🐞 Bugfixes
* Fix multi-tier template to allow optional header image (#1971) via
Josh Holtz (@joshdholtz)

### 🔄 Other Changes
* [Paywalls V2] Adds first version of `LoadedPaywallComponents` (#1970)
via JayShortway (@JayShortway)
* [Paywalls V2] Add `ButtonComponentView` (#1963) via Toni Rico
(@tonidero)
* [Paywalls V2] Adds `PaywallState.Loaded.Components` (#1969) via
JayShortway (@JayShortway)
* [Paywalls V2] Adds image background tests (#1967) via JayShortway
(@JayShortway)
* [Paywalls V2] `TextComponentView` updates when the theme changes
(#1966) via JayShortway (@JayShortway)
* [Paywalls V2] Adds a `StyleFactory` (#1965) via JayShortway
(@JayShortway)
* [EXTERNAL] fix: update polish translations (#1919) via @radko93
(#1964) via JayShortway (@JayShortway)
* [Paywalls V2] Adds `ImageComponentView` (#1959) via Toni Rico
(@tonidero)
* WebPurchaseRedemption: Rename `AlreadyRedeemed` result to
`PurchaseBelongsToOtherUser` (#1962) via Toni Rico (@tonidero)
* [Paywalls V2] Extends support for blurred shadows to all Android
versions (#1957) via JayShortway (@JayShortway)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants