Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework LocaleString handling for mods #43

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Rework LocaleString handling for mods #43

merged 4 commits into from
Jul 9, 2024

Conversation

Banane9
Copy link
Member

@Banane9 Banane9 commented Jul 8, 2024

No description provided.

@Banane9 Banane9 added the enhancement New feature or request label Jul 8, 2024
@Banane9 Banane9 self-assigned this Jul 8, 2024
@Banane9 Banane9 linked an issue Jul 8, 2024 that may be closed by this pull request
Ensure that users without a mod that uses localizations in Sessions don't see bare locale keys #44
Closed
@Banane9 Banane9 requested a review from Nytra July 8, 2024 18:38
@Banane9 Banane9 marked this pull request as ready for review July 8, 2024 18:38
@Banane9
Copy link
Member Author

Banane9 commented Jul 8, 2024

Here's what the setup looks like in game:
Effect of the components in game

Nytra
Nytra previously approved these changes Jul 9, 2024
View reviewed changes
MonkeyLoader.Resonite.Integration/Locale/ModLocaleDriverFix.cs Outdated Show resolved Hide resolved
@Banane9 Banane9 merged commit e42b300 into master Jul 9, 2024
1 check passed
@Banane9 Banane9 deleted the feature/rework-locale-string-handling branch July 9, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nytra Nytra Nytra left review comments

Assignees

@Banane9 Banane9

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that users without a mod that uses localizations in Sessions don't see bare locale keys
2 participants
@Banane9 @Nytra