Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that users without a mod that uses localizations in Sessions don't see bare locale keys #44

Closed
Banane9 opened this issue Jul 8, 2024 · 0 comments · Fixed by #43

Comments

@Banane9
Copy link
Member

Banane9 commented Jul 8, 2024

Currently, users who don't have a mod will see bare locale keys when mods (e.g. Component Selector Additions) use localized values in non-userspace sessions.

For this purpose, the LocaleHelper.DriveLocalized methods should be patched to add a BooleanValueDriver which only shows the output of the LocaleStringDriver when it's not equal to the locale key itself. Otherwise it should show the mod user's message for the locale key. Although ideally it would show the English value for it.

@Banane9 Banane9 linked a pull request Jul 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant