Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN-7791] fix(CV-PDF): left column width and display sections #409

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[EN-7791] fix(CV-PDF): left column width and display sections #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/cv/CVPDF/CVPDF.styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,8 @@ export const StyledCVPDFPage = styled.div`
`;

export const StyledCVPDFProfilePicture = styled(StyledCVProfilePicture)`
width: 128px;
height: 128px;
width: 128px !important;
height: 128px !important;
margin-top: ${({ verticalMargin }) => {
return verticalMargin ? '20px' : 0;
}};
Expand Down
4 changes: 2 additions & 2 deletions src/components/cv/CVPDF/CVPDF.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ export const CVPDF = ({ cv, page }: CVPDFProps) => {
availableSpaceOnFirstPage
);
setItems({
firstPageExperiences: cv.experiences.slice(0, nbOfExperienceFirstPage),
firstPageExperiences: cv.experiences, // all the xp on first page
firstPageFormations: cv.formations.slice(0, nbOfFormationFirstPage),
secondPageExperiences: cv.formations.slice(nbOfExperienceFirstPage),
secondPageExperiences: [], // no xp on second page
secondPageFormations: cv.formations.slice(nbOfFormationFirstPage),
Comment on lines -126 to 129
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est ce que c'est possible que les experiences prennent plus d'une page ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non dans tous les cas on peut afficher 5 éléments et on limite le nombre d'expérience à 5

});
}, [cv]);
Expand Down
1 change: 0 additions & 1 deletion src/components/partials/CV/PageCVContent/PageCVContent.styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ export const StyledCVProfilePictureContainer = styled.div`
export const StyledCVProfilePicture = styled.div`
height: 340px;
width: 340px;
background: red;
position: relative;
border-radius: 50%;
background-color: ${COLORS.hoverBlue};
Expand Down
Loading