[EN-7791] fix(CV-PDF): left column width and display sections #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillobits
temporarily deployed
to
entourage-job-front
GitHub Actions
Inactive
Default Project
|
||||||||||||||||||||||||||||||
| Project |
Default Project
|
| Branch Review |
fix/EN-7791-cv-leftCol-width
|
| Run status |
|
| Run duration | 06m 21s |
| Commit |
|
| Committer | CAUCHOIS Guillaume |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
42
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
DDZBX
reviewed
Dec 18, 2024
Comment on lines
-126
to
129
| firstPageExperiences: cv.experiences.slice(0, nbOfExperienceFirstPage), | ||
| firstPageExperiences: cv.experiences, // all the xp on first page | ||
| firstPageFormations: cv.formations.slice(0, nbOfFormationFirstPage), | ||
| secondPageExperiences: cv.formations.slice(nbOfExperienceFirstPage), | ||
| secondPageExperiences: [], // no xp on second page | ||
| secondPageFormations: cv.formations.slice(nbOfFormationFirstPage), |
There was a problem hiding this comment.
Est ce que c'est possible que les experiences prennent plus d'une page ?
There was a problem hiding this comment.
Non dans tous les cas on peut afficher 5 éléments et on limite le nombre d'expérience à 5
DDZBX
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.