feat(payment-processor): batch conversion - erc20 #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batch conv tests rename files clean batch tests batch deploy cleaning uncomment batchERC20ConversionPaymentsMultiTokensEasy test test: clean logs
add atchEth tested and contracts cleaned
* refactor: command to create request * fix: escrow audit fix 2 (#878) * fix(smart-contracts): update batch fees (#873) update batch fees from 1% to .3% * feat: add cancel stream function (#884) * refactor: contract setup compression fix (#888) * fix: escrow audit fix 2 (#878) * fix(smart-contracts): update batch fees (#873) update batch fees from 1% to .3% * feat: add cancel stream function (#884) * refactor: contract setup compression fix (#888) * feat: goerli storage (#890) feat: squash commits goerli storage * fix: delete ETHConversionProxy Co-authored-by: Darko Kolev <kolevdarko@gmail.com> Co-authored-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> Co-authored-by: Bertrand Juglas <b@juglas.name>
* refactor: factorize goerli tests * refactor: testSuite to testProvider * fix: delete goerli aggregator * feat: add void goerli chainlinkAggregator
feat: add goerli support
Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
….sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
….sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
….sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
github-actions
bot
requested review from
alexandre-abrioux,
benjlevesque and
kevindavee
leoslr
approved these changes
Sep 14, 2022
packages/payment-processor/src/payment/batch-conversion-proxy.ts
Outdated
Show resolved
Hide resolved
packages/payment-processor/src/payment/batch-conversion-proxy.ts
Outdated
Show resolved
Hide resolved
packages/payment-processor/src/payment/batch-conversion-proxy.ts
Outdated
Show resolved
Hide resolved
packages/payment-processor/test/payment/any-to-erc20-batch-proxy.test.ts
Show resolved
Hide resolved
olivier7delf
requested review from
bertux and
KolevDarko
and removed request for
benjlevesque,
alexandre-abrioux and
kevindavee
bertux
suggested changes
Sep 15, 2022
packages/payment-processor/src/payment/batch-conversion-proxy.ts
Outdated
Show resolved
Hide resolved
packages/payment-processor/test/payment/any-to-erc20-batch-proxy.test.ts
Outdated
Show resolved
Hide resolved
packages/payment-processor/test/payment/any-to-erc20-batch-proxy.test.ts
Outdated
Show resolved
Hide resolved
packages/payment-processor/test/payment/any-to-erc20-batch-proxy.test.ts
Outdated
Show resolved
Hide resolved
olivier7delf
requested review from
bertux
and removed request for
KolevDarko
bertux
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement payment processor for batch conversion proxy
It implements only the batchRouter function, which allows paying within a single transaction N heterogeneous (DAI-DAI, or EUR-DAI) payments.
Todo: implement the other method later, there have not been prioritized yet.