feat: add goerli support (advanced-logic) #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolevDarko
approved these changes
Aug 3, 2022
SPeshov
approved these changes
Aug 3, 2022
olivier7delf
pushed a commit
that referenced
this pull request
Aug 17, 2022
feat: add goerli support
olivier7delf
added a commit
that referenced
this pull request
Sep 16, 2022
* batch erc20 conversion contract and local deployment batch conv tests rename files clean batch tests batch deploy cleaning uncomment batchERC20ConversionPaymentsMultiTokensEasy test test: clean logs * tests batchPayments functions * clear batch contract * add comments in smart contract * add batchEthConversionPaymentsWithReference add atchEth tested and contracts cleaned * refacto batch contracts approval functions * PR - update batch contact - function visibility and comments * keep prefix underscore usage for function args * convention naming in batch contract and more comments * batchConv - delete chainlink implementation * batchConv erc20 - delete a require - add error tests * prettier contract * doc: modify command to create request (#880) * refactor: command to create request * fix: escrow audit fix 2 (#878) * fix(smart-contracts): update batch fees (#873) update batch fees from 1% to .3% * feat: add cancel stream function (#884) * refactor: contract setup compression fix (#888) * fix: escrow audit fix 2 (#878) * fix(smart-contracts): update batch fees (#873) update batch fees from 1% to .3% * feat: add cancel stream function (#884) * refactor: contract setup compression fix (#888) * feat: goerli storage (#890) feat: squash commits goerli storage * fix: delete ETHConversionProxy Co-authored-by: Darko Kolev <kolevdarko@gmail.com> Co-authored-by: olivier7delf <55892112+olivier7delf@users.noreply.github.com> Co-authored-by: Bertrand Juglas <b@juglas.name> * chore: update escrow addresses (#886) * feat: goerli payment (#892) * refactor: factorize goerli tests (#893) * refactor: factorize goerli tests * refactor: testSuite to testProvider * fix: delete goerli aggregator * feat: add void goerli chainlinkAggregator * feat: add goerli support (advanced-logic) (#895) feat: add goerli support * tmp * any-to-erc20-proxy payment - correct documention on proxy used * wip * refacto receive function - add comments to test functions * comments about unique token in smart contract * prettier * Update packages/smart-contracts/src/contracts/BatchPaymentsPublic.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchPaymentsPublic.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchPaymentsPublic.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchPaymentsPublic.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchConversionPayments.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchConversionPayments.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchConversionPayments.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchConversionPayments.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchConversionPayments.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchConversionPayments.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchConversionPayments.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchConversionPayments.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * Update packages/smart-contracts/src/contracts/BatchConversionPayments.sol Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com> * receive comment * tmp tests fail * batch calcul updated and tested - it includes fees now * delete basicFee inside the contract - update test - refacto script to deploy and local artifact * check the addresses of the contracts deployed and raise an error if needed * smart contract add variable tenThousand * contract require message - wording * smart contract delete chainlink * revert batchPayments modif * contract - remove irrelevant variable - wording uTokens * renaming requestInfo into conversionDetail and requestsInfoParent into cryptoDetails * contract - clean constructor * wording receive comments add batchEthPaymentsWithReference tests * clean packages * wip * refacto batch conversion ERC20 tests * eth batch functions tested * rewording and cleaning * refacto tests batch conversion ERC20 * refacto tests: batch conversion Eth * test erc20 can be run multiple time - revoke these approvals * test swap-erc-20-fee-proxy revoke approval * refacto any-to-erc20-proxy to create the function checkRequestAndGetPathAndCurrency * prettier * prettier test swap * batch conversion proxy functions and approvals * test batch erc20 * tests batch conversion payment done * prettier * clean tests and restore previous batchFee values * test refacto to simplify batchConvFunction * update batch conversion contract * clean escrow * version with errors on 2 proxies * make proxies public * batch conversion deploy on rinkeby * batch conversion deployed on goerli * clean test * update contract to make proxies public * fix import getPaymentNetworkExtension and its paymentReference undefined possibility * fix error message * rename batch conversion file * test refacto: delete emitOneTx - path and add before - adminSigner * deploy instead of connect to batchProxy * end cleaning old test version * refacto new test structure * refacto test add eth beginning * tests batchRouter erros * abi update prettier contract comments deploy and addresses * batch conv tests delete proxy global variables * test refactored * tests: cleaning * update batchConversionPayments proxies on rinkeby, goerli, and matic * add type for batch payment inputs * update processor with type * refacto feeAddress * refacto batch payment * clean history * refacto batch-conversion-proxy * refacto tests * cleaning * tests cleaning * refacto from PR comments * use type guards for ERC20 and ISO4217 currencies * PR comments B * add comments * convention if * Add every params description to functions * add batch proxy addresses Co-authored-by: Romain <45540622+rom1trt@users.noreply.github.com> Co-authored-by: Darko Kolev <kolevdarko@gmail.com> Co-authored-by: Bertrand Juglas <b@juglas.name> Co-authored-by: Yo <56731761+yomarion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Add goerli support in payment-network