Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update the contributing guidance #4222

Merged
merged 4 commits into from
Sep 30, 2024
Merged

doc: Update the contributing guidance #4222

merged 4 commits into from
Sep 30, 2024

Commits on Sep 29, 2024

  1. fix: datasource passed unicode to foreach_execute in py26 (RedHatInsi… 

    …ghts#4232)

- when collecting in py26 env, if the foreach_execute specs depends
  on DatasourceProvider, the provider will be in unicode type and causes
  the followed validate() fail
- this change converted the unicode to string by force for all 'cmd' passed to
  CommandOutputProvider

Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
    @xiangce
    xiangce authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    16406b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. doc: Update the contributing guidance 

    Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
    @xiangce
    xiangce committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9f7640f View commit details
    Browse the repository at this point in the history

  2. update the guidance per feedback 

    Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
    @xiangce
    xiangce committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    55375dd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into contributing_guide

    @xiangce
    xiangce authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0854713 View commit details
    Browse the repository at this point in the history