doc: Update the contributing guidance #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4222 +/- ##
=======================================
Coverage 76.69% 76.69%
=======================================
Files 759 759
Lines 41788 41788
Branches 9603 9603
=======================================
+ Hits 32049 32051 +2
+ Misses 8639 8638 -1
+ Partials 1100 1099 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JoySnow
reviewed
Sep 27, 2024
…ghts#4232) - when collecting in py26 env, if the foreach_execute specs depends on DatasourceProvider, the provider will be in unicode type and causes the followed validate() fail - this change converted the unicode to string by force for all 'cmd' passed to CommandOutputProvider Signed-off-by: Xiangce Liu <xiangceliu@redhat.com> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
xiangce
force-pushed
the
contributing_guide
branch
3 times, most recently
from
35f3eb9
to
2e1d000
Compare
Signed-off-by: Xiangce Liu <xiangceliu@redhat.com> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
xiangce
force-pushed
the
contributing_guide
branch
from
2e1d000
to
9f7640f
Compare
JoySnow
approved these changes
Sep 30, 2024
xiangce
force-pushed
the
contributing_guide
branch
from
378129c
to
01e540a
Compare
Signed-off-by: Xiangce Liu <xiangceliu@redhat.com> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
xiangce
force-pushed
the
contributing_guide
branch
from
01e540a
to
55375dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiangce Liu xiangceliu@redhat.com
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here