Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new 'Save As' feature to core collection #3992

Merged
merged 0 commits into from
Jan 25, 2024
Merged

feat: new 'Save As' feature to core collection #3992

merged 0 commits into from
Jan 25, 2024

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Jan 16, 2024

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

@xiangce xiangce changed the title feat: RHINENG-7584 - add 'Save As' feature to core collection feat: new 'Save As' feature to core collection Jan 19, 2024
@xiangce xiangce force-pushed the RHINENG-7584 branch 5 times, most recently from ed38bb3 to 463e4ec Compare January 22, 2024 12:03
@xiangce xiangce marked this pull request as ready for review January 22, 2024 12:03
@xiangce
Copy link
Contributor Author

xiangce commented Jan 23, 2024

@bfahr, @ryan-blakley and @JoySnow - please kindly review whenever free.

Copy link
Collaborator

@JoySnow JoySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xiangce , I am okay with the "save as" adding. Except this test assert usage below. Please kindly check.

insights/tests/test_specs_save_as.py Show resolved Hide resolved
@xiangce xiangce force-pushed the RHINENG-7584 branch 4 times, most recently from 396d029 to 95cd814 Compare January 25, 2024 08:10
@xiangce xiangce merged commit f98e6a2 into master Jan 25, 2024
7 of 8 checks passed
@xiangce xiangce deleted the RHINENG-7584 branch January 25, 2024 08:17
xiangce added a commit that referenced this pull request Jan 25, 2024
- See RHINENG-7584

Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>
(cherry picked from commit f98e6a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants