Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove legacy collection #3951

Closed
wants to merge 0 commits into from
Closed

refactor: remove legacy collection #3951

wants to merge 0 commits into from

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Nov 13, 2023

  • see INSGHTCORE-263
  • remove all dependent codes as well
  • and remove all relevant tests
  • update the script that generates the filters.yaml for Egg release

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Note: As it will be processed after INSGHTCORE-184, I rebased the branch of this PR on #3679.

@xiangce xiangce changed the title INSGHTCORE-263 Remove legacy collection [INSGHTCORE-263] Remove legacy collection Nov 13, 2023
@xiangce xiangce marked this pull request as draft November 13, 2023 05:36
@xiangce
Copy link
Contributor Author

xiangce commented Nov 13, 2023

Mark it as Draft for now, Will turn it to Ready after #3679

@xiangce xiangce changed the title [INSGHTCORE-263] Remove legacy collection refactor: remove legacy collection Nov 13, 2023
@xiangce xiangce mentioned this pull request Jan 22, 2024
Merged
3 tasks
@xiangce xiangce closed this Feb 2, 2024
@xiangce
Copy link
Contributor Author

xiangce commented Feb 2, 2024

Reopened in #4009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xiangce