Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(shareReplay): rename variable in example #4501

Merged
merged 1 commit into from
Jan 29, 2019
Merged

docs(shareReplay): rename variable in example #4501

merged 1 commit into from
Jan 29, 2019

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jan 28, 2019

Closes #4428

Description:

This PR renames the subscription variable - which is an Observable rather than a Subscription.

Related issue (if exists): #4428

@coveralls
Copy link

coveralls commented Jan 28, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 7968

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.813%
Totals Coverage Status
Change from base Build 7960: 0.0%
Covered Lines: 5256
Relevant Lines: 5429
💛 - Coveralls

@benlesh benlesh merged commit fb24303 into ReactiveX:master Jan 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 1, 2019
@cartant cartant deleted the issue-4428 branch September 24, 2020 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benlesh benlesh benlesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartant @coveralls @benlesh