Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxjs-dev docs shareReplay example variable 'subscription' might better be called 'observable' #4428

Closed
egretsRegrets opened this issue Dec 18, 2018 · 0 comments
Labels
docs Issues and PRs related to documentation

Comments

@egretsRegrets
Copy link

Documentation Related To Component:

shareReplay

Please check those that apply

  • documentation needs clarification

Description Of The Issue

I could be wrong, but in the brief example I think the variable called 'subscription' would actually be of the type 'Observable' and should probably be called 'observable' to prevent confusion. Here's the example as it exists today:

const subscription = obs$.pipe(
  take(4),
  shareReplay(3)
);
subscription.subscribe(x => console.log('source A: ', x));
subscription.subscribe(y => console.log('source B: ', y));```
@niklas-wortmann niklas-wortmann added the docs Issues and PRs related to documentation label Jan 16, 2019
cartant added a commit to cartant/rxjs that referenced this issue Jan 28, 2019
cartant added a commit to cartant/rxjs that referenced this issue Jan 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issues and PRs related to documentation
Projects
None yet
Development

No branches or pull requests

2 participants