Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(tsconfig): introduce extended tsconfig for target #3019

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Oct 30, 2017

Description:
This PR is effort to simplify our npm script, as first step instead of repeating whole same configuration for each build targes, utilizes latest tsc's config extending.

Related issue (if exists):

@rxjs-bot
Copy link

Messages
📖

CJS: 1397.1KB, global: 756.2KB (gzipped: 120.9KB), min: 147.0KB (gzipped: 31.6KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.261% when pulling 385478b on kwonoj:chore-ts-config into 2f395da on ReactiveX:master.

@kwonoj
Copy link
Member Author

kwonoj commented Oct 30, 2017

/cc @jasonaden for visibility.

Copy link
Collaborator

@jasonaden jasonaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to be for v6? I saw the earlier PR to bring TypeScript to latest which is great, but only for v6, right? Otherwise we run the risk of producing a d.ts file that's not compatible with earlier versions of TypeScript.

@kwonoj
Copy link
Member Author

kwonoj commented Oct 30, 2017

Yes, this is targeting master only which for v6 and further. Ben branched off 5.5 stable for minor fixes.

Copy link
Collaborator

@jasonaden jasonaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@benlesh
Copy link
Member

benlesh commented Oct 31, 2017

This is SO MUCH BETTER.

@benlesh benlesh merged commit 3b66a0b into ReactiveX:master Oct 31, 2017
@kwonoj kwonoj deleted the chore-ts-config branch October 31, 2017 03:38
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants