Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve compiler errors in test cases by implicit any #3020

Closed
kwonoj opened this issue Oct 30, 2017 · 3 comments · Fixed by Xenira/Shashki#66
Closed

Resolve compiler errors in test cases by implicit any #3020

kwonoj opened this issue Oct 30, 2017 · 3 comments · Fixed by Xenira/Shashki#66
Labels
feature PRs and issues for features help wanted Issues we wouldn't mind assistance with.

Comments

@kwonoj
Copy link
Member

kwonoj commented Oct 30, 2017

RxJS version:

Code to reproduce:

Expected behavior:

Actual behavior:

Additional information:
With latest PR #3019, running tsc on top of repo with tsconfig.json will bring up whole bloat of compilation error by our spec has numbers of implicit any declaration. This is dept we need to pay off and enable those compilation in CI to prevent it happens again.
@kwonoj kwonoj added help wanted Issues we wouldn't mind assistance with. feature PRs and issues for features labels Oct 30, 2017
@davidkpiano davidkpiano mentioned this issue Oct 30, 2017
Merged
@kwonoj kwonoj closed this as completed in 01d1575 Nov 5, 2017
kwonoj added a commit that referenced this issue Nov 5, 2017
@kwonoj
Merge pull request #3022 from davidkpiano/issue-3020
be70534 
fix(TSC): Fixing TSC errors. Fixes #3020
@kwonoj kwonoj reopened this Nov 5, 2017
@kwonoj
Copy link
Member Author

kwonoj commented Nov 5, 2017

Suggested PR doesn't work, reopen issue.

@kwonoj
Copy link
Member Author

kwonoj commented Nov 5, 2017

To clarify, to try out this just run tsc on top of repo using base tsconfig.json, not via any other npm scripts in our repo.

@kwonoj kwonoj closed this as completed in ad4e2bd Nov 5, 2017
kwonoj added a commit that referenced this issue Nov 5, 2017
@kwonoj
Merge pull request #3051 from ReactiveX/revert-3022-issue-3020
7fd366b 
Revert "fix(TSC): Fixing TSC errors. Fixes #3020"
@kwonoj kwonoj mentioned this issue Dec 5, 2017
Closed
@kwonoj kwonoj mentioned this issue Mar 8, 2018
Closed
@dependabot-preview dependabot-preview bot mentioned this issue Mar 14, 2018
Merged
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature PRs and issues for features help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump rxjs from 5.5.6 to 5.5.7 in /frontend Xenira/Shashki
1 participant
@kwonoj