Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(closure): don't throw at top-level scope #2546

Merged
merged 1 commit into from
Apr 12, 2017
Merged

fix(closure): don't throw at top-level scope #2546

merged 1 commit into from
Apr 12, 2017

Commits on Apr 12, 2017

  1. fix(closure): make root.ts work with closure 

    1) don't throw at top-level scope.
Closure compiler does not allow this if a goog.module statement is present in the file. We need this modification to use RxJS with angular/tsickle.
Addresses angular/tsickle#420

2) refactor the conditional logic for finding the root object
See alexeagle/closure-compiler-angular-bundling#15
Closure seems to statically reduce the existing code and eliminates the conditional, making it always throw.
    @alexeagle
    alexeagle committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    78a0193 View commit details
    Browse the repository at this point in the history