fix(closure): don't throw at top-level scope

[alexeagle]

Closure compiler does not allow this. We need this modification to use RxJS in Angular projects.

Addresses angular/tsickle#420

Description:

Related issue (if exists):

[kwonoj]

this looks ok to me.

[alexeagle]

Note, this is the minimal fix. You could instead just avoid throwing an exception: it's unclear from module semantics whether such a throw will abort execution of this one module, or the loading of the whole program. You'd be just as well with a runtime error when attempting to access the root property if it doesn't match one of the conditions above. (suggested by @evmar)

[coveralls]

Coverage increased (+0.0003%) to 97.687% when pulling cafa477 on alexeagle:patch-1 into dc2e7f1 on ReactiveX:master.

[alexeagle]

Hold on merging this please, it looks like there is still an issue with closure compiler in the newest release. I'll figure it out tomorrow...

[alexeagle]

okay, fixed now @benlesh.
Exciting news: this is the only change needed to make Angular and Closure work, we don't need the ESM distro.

[coveralls]

Coverage decreased (-0.04%) to 97.644% when pulling 78a0193 on alexeagle:patch-1 into dc2e7f1 on ReactiveX:master.

[benlesh]

Note, this is the minimal fix. You could instead just avoid throwing an exception: it's unclear from module semantics whether such a throw will abort execution of this one module, or the loading of the whole program

Yeah, overall this throwing seems odd (I probably added it). I've often wondered if we could get around this whole root module to begin with.

This LGTM tho, next patch version.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.