style(linting): enable 'noImplicitThis' compiler option

[tetsuharuohzeki]

Description:

• This intent to make this type explicitly.
  • This would make our codes more type safe with a compiler enforcement.
  • This makes our API documentation better.
• I think this would not be a breaking change by these reasons:
  • There are no problem if we pass the function which does not has this specifying.
  • There are no problem if we pass the function which has this: any or this.
    • This case is valid with the actual behavior.
  • If we pass the function which has invalid this type
    then, basically, its code would be wrong.

Related issue (if exists):

• Fix feat(TypeScript): enable 'noImplicitThis' options #1971.
• Related: refactor(Scheduler): clearify the signature which Scheduler.schedule() takes as work. #2078

[coveralls]

Coverage remained the same at 97.593% when pulling 1074cb7 on saneyuki:noImplicitThis into 39214f2 on ReactiveX:master.

[jayphelps]

I don't believe this and #2104 are features (i.e. publicly accessible API/behavior additions). They are more like a refactor. Anyone else have thoughts?

[kwonoj]

@jayphelps I agree, as these change should not impact public api surface.

for this one, as shared in original issue I'm not in great favor of this changes while I would not suggest to block check in completely. My experience with this flag usually caused unnecessary pain point for some tricky cases

[david-driscoll]

@kwonoj do you have specific cases? With the new this syntax I've not had any issues. I've had lots of problems with tslint in the past though.

[kwonoj]

@david-driscoll sorry, it was bit while and I don't have examples for now.

[tetsuharuohzeki]

@jayphelps

I don't believe this and #2104 are features (i.e. publicly accessible API/behavior additions). They are more like a refactor. Anyone else have thoughts?

Okay. I'll change to style(linting).

[coveralls]

Coverage remained the same at 97.595% when pulling becad1c on saneyuki:noImplicitThis into bf3c043 on ReactiveX:master.

[jayphelps]

LGTM

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.