refactor(Scheduler): clearify the signature which Scheduler.schedule() takes as work.
#2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetsuharuohzeki
changed the title
Scheduler.scheduler takes as work.Scheduler.schedule() takes as work.
tetsuharuohzeki
force-pushed
the
clarify-this-of-Scheduler-schedule
branch
from
50ee953 to
8e77086
Compare
|
@saneyuki the build is failing after this change. |
tetsuharuohzeki
force-pushed
the
clarify-this-of-Scheduler-schedule
branch
from
8e77086 to
0d8864c
Compare
fixed. |
tetsuharuohzeki
force-pushed
the
clarify-this-of-Scheduler-schedule
branch
from
0d8864c to
103f0ad
Compare
…()` takes as `work`. I think this would not be a breaking change by these reasons: - There are no problem if we pass the function which does not has `this` specifying. - There are no problem if we pass the function which has `this: any` or `this: Action<T>`. - This case is valid with the actual behavior. - If we pass the function which has `this: SomeNonValidTypeWithAction<T>`, then, basically, its code would be wrong.
tetsuharuohzeki
force-pushed
the
clarify-this-of-Scheduler-schedule
branch
from
4e1d2cc to
124a048
Compare
|
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
thisspecifying.this: anyorthis: Action<T>.this: SomeNonValidTypeWithAction<T>,then, basically, its code would be wrong.