Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: inline disposability in Obs.concatMap(Completable) #5652

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Oct 9, 2017

The inner Observer type and the SequentialDisposable of the concatMap and concatMapCompletable can be combined into a single instance, saving on indirection and allocation.

(I've noticed this when reviewing #5649.)

@akarnokd akarnokd added this to the 2.2 milestone Oct 9, 2017
@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #5652 into 2.x will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5652      +/-   ##
============================================
- Coverage     96.24%   96.21%   -0.03%     
+ Complexity     5851     5848       -3     
============================================
  Files           635      635              
  Lines         41652    41651       -1     
  Branches       5768     5768              
============================================
- Hits          40087    40074      -13     
- Misses          622      626       +4     
- Partials        943      951       +8
Impacted Files Coverage Δ Complexity Δ
...rnal/operators/observable/ObservableConcatMap.java 97.52% <100%> (ø) 5 <0> (ø) ⬇️
...ors/observable/ObservableConcatMapCompletable.java 96.29% <100%> (-0.04%) 2 <0> (ø)
.../io/reactivex/internal/functions/ObjectHelper.java 94.73% <0%> (-5.27%) 20% <0%> (-1%)
...erators/completable/CompletableConcatIterable.java 95.91% <0%> (-4.09%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.17% <0%> (-3.93%) 2% <0%> (ø)
...vex/internal/operators/single/SingleTakeUntil.java 91.8% <0%> (-3.28%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 92.3% <0%> (-2.57%) 6% <0%> (ø)
...ex/internal/subscribers/InnerQueuedSubscriber.java 96.07% <0%> (-1.97%) 18% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 97.24% <0%> (-1.84%) 39% <0%> (-1%)
...java/io/reactivex/processors/PublishProcessor.java 98.29% <0%> (-1.71%) 45% <0%> (-1%)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abd86a...be8ac51. Read the comment docs.

@akarnokd akarnokd merged commit 1b0cd2a into ReactiveX:2.x Oct 9, 2017
@akarnokd akarnokd deleted the ObsConcatMapInlineDisposable branch October 9, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants