2.x Add concatMapCompletable() to Observable #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #5649 +/- ##
============================================
- Coverage 96.19% 96.15% -0.05%
- Complexity 5843 5849 +6
============================================
Files 634 635 +1
Lines 41539 41652 +113
Branches 5752 5768 +16
============================================
+ Hits 39960 40050 +90
- Misses 626 640 +14
- Partials 953 962 +9
Continue to review full report at Codecov.
|
akarnokd
reviewed
Oct 6, 2017
| * @param mapper | ||
| * a function that, when applied to an item emitted by the source ObservableSource, returns a CompletableSource | ||
| * @return a Completable that signals {@code onComplete} when the upstream and all CompletableSources complete | ||
| */ |
There was a problem hiding this comment.
Please add @since 2.1.6 - experimental
| */ | ||
| @CheckReturnValue | ||
| @SchedulerSupport(SchedulerSupport.NONE) | ||
| public final Completable concatMapCompletable(Function<? super T, ? extends CompletableSource> mapper) { |
| * @param prefetch | ||
| * the number of elements to prefetch from the current Observable | ||
| * @return a Completable that signals {@code onComplete} when the upstream and all CompletableSources complete | ||
| */ |
| */ | ||
| @CheckReturnValue | ||
| @SchedulerSupport(SchedulerSupport.NONE) | ||
| public final Completable concatMapCompletable(Function<? super T, ? extends CompletableSource> mapper, int prefetch) { |
| * | ||
| * @param mapper | ||
| * a function that, when applied to an item emitted by the source ObservableSource, returns a CompletableSource | ||
| * @param prefetch |
There was a problem hiding this comment.
A capacityHint would capture the underlying behavior better: "the number of upstream items expected to be buffered until the current CompletableSource, mapped from the current item, completes."
akarnokd
reviewed
Oct 6, 2017
There was a problem hiding this comment.
Codewise it looks okay. /cc @artem-zinnatullin, @vanniktech & @davidmoten who was also interested in this.
vanniktech
approved these changes
Oct 7, 2017
| @CheckReturnValue | ||
| @SchedulerSupport(SchedulerSupport.NONE) | ||
| public final Completable concatMapCompletable(Function<? super T, ? extends CompletableSource> mapper) { | ||
| return concatMapCompletable(mapper, 2); |
There was a problem hiding this comment.
Should not we pass 8 here since it'll get overridden to 8 in the implementation?
|
Added to #5319 for the diagram. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
concatMapCompletable()toObservableas discussed in #4853I didn't think it made sense in other reactive types.
Code is mostly a copy of
ObservableConcatMap. Let me know if there is a better style of code to base this off instead. It also does not have the option to delay errors as concatMap() does, not sure if that is needed.