2.x: Fix subscribeWith documentation examples #5647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves a documentation of
subscribeWith
functions inSingle
,Maybe
,Completable
by making sure examples are compilable (by using classes which implementDisposable
).This should fix issue #5642 .
In that issue @akarnokd approved my idea to use
DisposableMaybeObserver
in the example, but as I looked in other classes, I noticed thatObservable.subscribeWith()
documentation uses aResourceObserver
(which implementsDisposable
), so I thought that this is the way to go in all other top-classes?If you think that this is not the case, and instead all of them should be switched to use
Disposable*Observer
in their examples, let me know, I will do it in this way then.I think that all those example should use similar classes.