Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe.subscribeWith() has incorrect documentation #5642

Closed
dimsuz opened this issue Oct 4, 2017 · 2 comments
Closed

Maybe.subscribeWith() has incorrect documentation #5642

dimsuz opened this issue Oct 4, 2017 · 2 comments

Comments

@dimsuz
Copy link
Contributor

dimsuz commented Oct 4, 2017

Maybe.subscribeWith() documentation suggests that it returns a Disposable and contains this example (translated to Kotlin):

    val source = Maybe.just(1)
    val composite = CompositeDisposable()
    val ms = object : MaybeObserver<Int> {
      // ...
    }
    composite.add(source.subscribeWith(ms))

This code does not compile, because MaybeObserver does not implement Disposable.

Should the documentation suggest to use DisposableMaybeObserver here?
If yes, I can submit a PR.

@akarnokd
Copy link
Member

akarnokd commented Oct 4, 2017

Yes, DisposableMaybeObserver should be there. PR welcome.

@dimsuz
Copy link
Contributor Author

dimsuz commented Oct 9, 2017

Closing as PR got merged.

@dimsuz dimsuz closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants