2.x: TestObserver shouldn't clear the upstream disposable on terminated #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.75% (diff: 100%)@@ 2.x #4873 diff @@
==========================================
Files 581 581
Lines 37214 37212 -2
Methods 0 0
Messages 0 0
Branches 5601 5601
==========================================
+ Hits 35624 35634 +10
+ Misses 656 650 -6
+ Partials 934 928 -6
|
JakeWharton
approved these changes
Nov 22, 2016
This was referenced Nov 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestObserverreplaced the upstream'sDisposablewith the disposed-sentinel when it got a terminal event (unlikeTestSubscriber) and there seems to be a need for triggeringdisposein some upstream even after that. This PR changes this behavior and also updates unit tests that expectisDisposed()true without actually callingdispose().Related #4872