Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests break with RxJava 2.0.2+ #201

Closed
Jawnnypoo opened this issue Feb 23, 2017 · 2 comments
Closed

Tests break with RxJava 2.0.2+ #201

Jawnnypoo opened this issue Feb 23, 2017 · 2 comments

Comments

@Jawnnypoo
Copy link

I am trying to investigate what exactly is going on, but currently, if you update the library to 2.0.2 and beyond and run the tests, RxLifecycleTest.testBindLifecycle and RxLifecycleTest.testBindLifecycleOther fail with the test observer being disposed.

I am thinking it might be related to this PR?
ReactiveX/RxJava#4873
@dlew dlew mentioned this issue Mar 1, 2017
Merged
@dlew
Copy link
Contributor

dlew commented Mar 1, 2017

Thanks for reporting. It is indeed related to that PR.

Fixing it only involved modifying tests, so I'm not going to release a new version of RxLifecycle; the internals of the library are still sound.

@Jawnnypoo
Copy link
Author

Ah okay, glad to hear it! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlew @Jawnnypoo