-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate the translational mode if doesn't exist #1620
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1620 +/- ##
======================================
Coverage 41.5% 41.5%
======================================
Files 176 176
Lines 29306 29306
Branches 6033 6033
======================================
Hits 12163 12163
Misses 16292 16292
Partials 851 851 Continue to review full report at Codecov.
|
@cgrambow, can I pick your brain for why we still see discrepancies for O and S's entropy? Any lead? |
I haven't looked at your code, but I went ahead and calculated HCSON by hand (see attached file). My results are:
That's the same as ARC/Arkane gets, it seems (based on your graph), so I think ARC is calculating the partition functions correctly. That calculation assumes that excited states are inaccessible. The full electronic partition function would be In conclusion, there is no error in Arkane/ARC and we can only do better if we modify the electronic partition function to include excited state energies. As an aside: @mjohnson541, The |
Thanks so much for the detailed response, @cgrambow !! |
Sometimes the translational mode is not appended to modes for monoatomic species. If it doesn't exist, determine it from the mass.
Can do! I am taking a look at it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Colin's explanation also makes sense to me, so I think this is good to go.
Should this be included in the v2.4.0 release? |
@mliu49, I think the code review should not take too long, and we do fix a bug here, so YES - we should include it in the release. But I wouldn't want the release to just wait for this PR, if it comes to this then it's also OK to release w/o this. |
No problem, we can definitely get it in. It seems that @amarkpayne already approved this. Is it ready to be merged? |
Yes - just waiting on RMG-Tests... (I restarted since it got stuck) |
Motivation or Problem
Arkane determines poor entropies for atoms. The reason is that it appends a translational partition function to modes only if it finds, e.g., 'Molecular mass:' in a Gaussian input file, but that line appears in a freq calculation, not in an sp calculation log file (atoms only have the latter, which is passed to Arkane as the frequency log file as well).
As a result, we get great H298's, but poor S298's:
Description of Changes
Detect if the translational mode was not appended to the conformer modes, and if so determine it from the mass and append it.
This results in improved S298:
Much, much better, but could still be improved for O and S (I don't know what the source for the deviation is).