Ensure .so install name & filename match on OSX (fixes #1144) #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS X convention requires that the basename part of a shared library's install name (i.e., install name minus directory components) match the actual filename of said shared library. Otherwise, the dynamic linker (and related tools) could get confused when trying to find, process, and/or load the dynamic library. On OS X, the "mv" command at the end of the build process changes the shared library filename to "datatable.so" while leaving the install name as "data.table.so", so we need to run install_name_tool(1) to fix the install name to match the filename. Currently not a big issue for most users (since not much else links to this shared library), but not doing this causes issues with build systems (e.g., conda) that end up modifying the .so's RPATH for some reason.
arunsrinivasan
added a commit
that referenced
this pull request
Dec 1, 2015
Ensure .so install name & filename match on OSX (fixes #1144)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS X convention requires that the basename part of a shared library's
install name (i.e., install name minus directory components) match the
actual filename of said shared library. Otherwise, the dynamic linker
(and related tools) could get confused when trying to find, process,
and/or load the dynamic library.
On OS X, the "mv" command at the end of the build process changes the
shared library filename to "datatable.so" while leaving the install name
as "data.table.so", so we need to run install_name_tool(1) to fix the
install name to match the filename. Currently not a big issue for most
users (since not much else links to this shared library), but not doing
this causes issues with build systems (e.g., conda) that end up
modifying the .so's RPATH for some reason.