Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the install name of datatable.so on OS X #1144

Closed
asmeurer opened this issue May 11, 2015 · 1 comment
Closed

Change the install name of datatable.so on OS X #1144

asmeurer opened this issue May 11, 2015 · 1 comment

Comments

@asmeurer
Copy link

The build changes data.table.so to datatable.so, but it doesn't change the install name on OS X (otool -L datatable.so), so future things that link against it will pull in the wrong install name. The build should use install_name_tool -id datatable.so path/to/datatable.so to change the install name to match the file name (or probably better, compile it as datatable.so in the first place).
arunsrinivasan added a commit that referenced this issue Dec 1, 2015
@arunsrinivasan
Merge pull request #1457 from chenghlee/fix-1144
5227e80 
Ensure .so install name & filename match on OSX (fixes #1144)
@asmeurer
Copy link
Author

asmeurer commented Dec 1, 2015

👍

@arunsrinivasan arunsrinivasan mentioned this issue May 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asmeurer